siddharthteotia commented on code in PR #9708:
URL: https://github.com/apache/pinot/pull/9708#discussion_r1011233715
##########
pinot-core/src/test/java/org/apache/pinot/queries/TextSearchQueriesTest.java:
##########
@@ -1864,6 +1878,26 @@ public void testInterSegment() {
query = "SELECT count(*) FROM MyTable WHERE
TEXT_MATCH(SKILLS_TEXT_COL_DICT, 'a and or in the are')";
testInterSegmentAggregationQueryHelper(query, 0);
+ // query with excluded stop-words. they should be indexed
+ query = "SELECT count(*) FROM MyTable WHERE TEXT_MATCH(SKILLS_TEXT_COL,
'\"IT support\" or \"IT manager\"')";
+ testInterSegmentAggregationQueryHelper(query, 8);
+
+ // query with excluded stop-words. they should be indexed
+ query = "SELECT count(*) FROM MyTable WHERE TEXT_MATCH(SKILLS_TEXT_COL,
'\"IT\"')";
+ testInterSegmentAggregationQueryHelper(query, 16);
+
+ // query without stop-words
+ query = "SELECT count(*) FROM MyTable WHERE TEXT_MATCH(SKILLS_TEXT_COL,
'\"support\" or \"manager\"')";
+ testInterSegmentAggregationQueryHelper(query, 12);
Review Comment:
Can we add a test where for another text index column, we don't set the
excludeStopWords IT in the FieldConfig and thus the result of search `'\"IT
support\" or \"IT manager\"'` is same as `'\"support\" or \"manager\"'` which
is 12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
