walterddr commented on code in PR #9707:
URL: https://github.com/apache/pinot/pull/9707#discussion_r1012183017
##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##########
@@ -147,4 +157,48 @@ public static FunctionInfo getFunctionInfo(String
functionName, int numParameter
private static String canonicalize(String functionName) {
return StringUtils.remove(functionName, '_').toLowerCase();
}
+
+ /**
+ * Placeholders for scalar function, they register and represents the
signature for transform and filter predicate
+ * so that v2 engine can understand and plan them correctly.
+ */
+ private static class PlaceholderScalarFunctions {
+
+ public static Object jsonExtractScalar(String jsonFieldName, String
jsonPath, String resultsType) {
+ throw new UnsupportedOperationException("Placeholder scalar function,
should not reach here");
+ }
+
+ public static Object jsonExtractScalar(String jsonFieldName, String
jsonPath, String resultsType,
+ Object defaultValue) {
+ throw new UnsupportedOperationException("Placeholder scalar function,
should not reach here");
+ }
+
+ public static String jsonExtractKey(String jsonFieldName, String jsonPath)
{
+ throw new UnsupportedOperationException("Placeholder scalar function,
should not reach here");
+ }
+
+ public static long timeConvert(String timeConvertInput, String fromFormat,
String toFormat) {
+ throw new UnsupportedOperationException("Placeholder scalar function,
should not reach here");
+ }
+
+ public static long extract(String extractFormat, long timestamp) {
+ throw new UnsupportedOperationException("Placeholder scalar function,
should not reach here");
+ }
+
+ // CHECKSTYLE:OFF
+ // @formatter:off
Review Comment:
no need. have to fix alias anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
