amrishlal commented on code in PR #9708:
URL: https://github.com/apache/pinot/pull/9708#discussion_r1012229530
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -319,12 +319,16 @@ public long getLatestIngestionTimestamp() {
// Text index
MutableTextIndex textIndex;
+ List<String> stopWordsInclude = null;
+ List<String> stopWordsExclude = null;
Review Comment:
Minor: it seems like this is the only reason why a null check is needed in
`getStandardAnalyzerWithCustomizedStopWords` for `stopWordsInclude` and
`stopWordsExclude`. Otherwise, all the other places that create stop world
list are returning non null `List<String>` and marked as `NonNull`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
