siddharthteotia commented on code in PR #9678:
URL: https://github.com/apache/pinot/pull/9678#discussion_r1012267144
##########
pinot-core/src/test/java/org/apache/pinot/queries/RangeQueriesTest.java:
##########
@@ -223,6 +223,42 @@ public void testSelectionOverRangeFilter(String query, int
min, int max, boolean
}
}
+ @Test(dataProvider = "selectionTestCases")
+ public void testSelectionOverRangeFilterAfterReload(String query, int min,
int max, boolean inclusive)
Review Comment:
We should add other tests like
- Run query on a raw column using that in filter
- Enable dict + reload
- Run same query again and it should use dict based predicate evaluator and
return same result
Same goes for using the column in SELECT clause. It should correctly return
the same result after doing dual lookup in rewriten fwd index and dict as it
did before with raw fwd index. Things like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
