siddharthteotia commented on code in PR #9678:
URL: https://github.com/apache/pinot/pull/9678#discussion_r1012329439
##########
pinot-core/src/test/java/org/apache/pinot/queries/RangeQueriesTest.java:
##########
@@ -232,4 +268,38 @@ public void testCountOverRangeFilter(String query, int
expectedCount) {
assertEquals(aggregationResult.size(), 1);
assertEquals(((Number) aggregationResult.get(0)).intValue(),
expectedCount, query);
}
+
+ @Test(dataProvider = "countTestCases")
+ public void testCountOverRangeFilterAfterReload(String query, int
expectedCount)
Review Comment:
- SELECT <particularColumn> FROM foo LIMIT <everything> -- this will test
out that dict is correct and fwd index got rewritten
- Try the same in GROUP BY as GROUP BY uses dict.
- Try MIN and MAX aggregations -- they can be answered from dict.
- WHERE clause like mentioned in another commend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
