npawar commented on code in PR #9719:
URL: https://github.com/apache/pinot/pull/9719#discussion_r1013496785
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -468,6 +468,13 @@ void downloadAndReplaceSegment(String segmentName,
SegmentZKMetadata segmentZKMe
private void downloadSegmentFromDeepStore(String segmentName,
IndexLoadingConfig indexLoadingConfig, String uri) {
File segmentTarFile = new File(_indexDir, segmentName +
TarGzCompressionUtils.TAR_GZ_FILE_EXTENSION);
Review Comment:
this code is very difficult to unit test, so for the sake of not creating
any other side effects, I would prefer to leave it at this simple check.. I
don't feel confident moving the segmentTarFile into a tmp dir and not breaking
something else..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
