walterddr commented on code in PR #9726:
URL: https://github.com/apache/pinot/pull/9726#discussion_r1014098543
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTest.java:
##########
@@ -157,6 +157,9 @@ private void compareRowEquals(List<Object[]> resultRows,
List<Object[]> expected
@DataProvider(name = "testDataWithSqlToFinalRowCount")
private Object[][] provideTestSqlAndRowCount() {
return new Object[][] {
+ // Hybrid table - hybrid table has a 1-day cut-off from current, so it
will always use REALTIME only
Review Comment:
i was thinking about this too. this is precisely why, as you suggested, we
shouldn't generate a 5 row segment. previously ts is always current timestamp
and thus hard to debug
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -127,29 +128,44 @@ protected void addDataToH2(Map<String, List<GenericRow>>
rowsMap)
public void setUp()
throws Exception {
DataTableBuilderFactory.setDataTableVersion(DataTableFactory.VERSION_4);
- QueryServerEnclosure server1 = new QueryServerEnclosure(
- ImmutableMap.of("a", INDEX_DIR_S1_A, "b", INDEX_DIR_S1_B, "c",
INDEX_DIR_S1_C, "d_O", INDEX_DIR_S1_D),
- QueryEnvironmentTestUtils.SERVER1_SEGMENTS);
- QueryServerEnclosure server2 = new QueryServerEnclosure(
- ImmutableMap.of("a", INDEX_DIR_S2_A, "c", INDEX_DIR_S2_C, "d_R",
INDEX_DIR_S2_D, "d_O", INDEX_DIR_S1_D),
- QueryEnvironmentTestUtils.SERVER2_SEGMENTS);
+ MockInstanceDataManagerFactory factory1 = new
MockInstanceDataManagerFactory("server1")
+
.registerTable(QueryEnvironmentTestBase.SCHEMA_BUILDER.setSchemaName("a").build(),
"a_REALTIME")
Review Comment:
table can have 0 segments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
