walterddr commented on code in PR #9702:
URL: https://github.com/apache/pinot/pull/9702#discussion_r1014651863
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ObjectFunctions.java:
##########
@@ -92,13 +94,40 @@ private static Object coalesceVar(Object... objects) {
return null;
}
- @Nullable
- private static Object coalesce(Object... objects) {
- for (Object o : objects) {
- if (o != null) {
- return o;
+ @ScalarFunction
+ public static Object caseWhen(boolean c1, Object o1, Object oe) {
Review Comment:
not really. the info passed over to the stages contains SqlOperator and
function. it will use SqlOperator to lookup first before using function name.
thus v1 engine will correctly composed out the transform version of the "case";
and intermediate stage will use the scalar function correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
