agavra commented on code in PR #9765: URL: https://github.com/apache/pinot/pull/9765#discussion_r1017341668
########## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/queries/BasicQueryTest.java: ########## @@ -0,0 +1,32 @@ +package org.apache.pinot.query.runtime.queries; + +import com.google.common.collect.ImmutableList; +import com.google.common.collect.ImmutableMap; +import java.util.ArrayList; +import java.util.List; +import org.apache.pinot.spi.data.FieldSpec; + + +/** + * This is a basic test for executiong QueryRunnerTestCases with various different configurations. + */ Review Comment: nice! I like this a lot - it'd be good if we used `@Parameterized` instead of a static block so that we could have individual test results in the TestNG output. Otherwise this is 💯🔥🔥🔥 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
