61yao commented on code in PR #9767:
URL: https://github.com/apache/pinot/pull/9767#discussion_r1017423971
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/AggregateOperatorTest.java:
##########
@@ -51,4 +233,27 @@ public void testGroupByAggregateWithHashCollision() {
Assert.assertEquals(resultRows.get(0), expectedRows.get(0));
Assert.assertEquals(resultRows.get(1), expectedRows.get(1));
}
+
+ @Test(
+ expectedExceptions = IllegalStateException.class,
+ expectedExceptionsMessageRegExp = ".*Unexpected value: AVERAGE.*")
+ public void shouldThrowOnUnknownAggFunction() {
Review Comment:
Can we also have a test covering when the input type is not a number? I
assume this will throw an exception in Java?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
