walterddr commented on code in PR #9765:
URL: https://github.com/apache/pinot/pull/9765#discussion_r1018518515
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -198,11 +242,27 @@ private static List<String>
toH2FieldNamesAndTypes(org.apache.pinot.spi.data.Sch
case STRING:
fieldType = "varchar(128)";
break;
+ case DOUBLE:
+ fieldType = "double";
+ break;
default:
throw new UnsupportedOperationException("Unsupported type conversion
to h2 type: " + dataType);
}
fieldNamesAndTypes.add(fieldName + " " + fieldType);
}
return fieldNamesAndTypes;
}
+
+ public static class TestCase {
Review Comment:
done to some extend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
