walterddr commented on code in PR #9755:
URL: https://github.com/apache/pinot/pull/9755#discussion_r1019248407
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/TransferableBlock.java:
##########
@@ -76,7 +83,7 @@ public DataSchema getDataSchema() {
*
* @return data container.
*/
- public List<Object[]> getContainer() {
Review Comment:
actually nvm. with the leaf node split and all. we might not want to change
this API and instead we should ask the orderby combine operator to flatten the
priorityqueue into a list.
1. it won't be preserving the sorted structure anyway if transfer over the
wire
2. the whole idea is to avoid extra memory usage not save time, but it seems
like we have to do it anyway, with split block and all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
