walterddr commented on code in PR #9792:
URL: https://github.com/apache/pinot/pull/9792#discussion_r1022961573
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java:
##########
@@ -204,6 +204,7 @@ public FieldSpec.DataType getDataType() {
class FunctionCall implements RexExpression {
@ProtoProperties
private SqlKind _sqlKind;
+ // TODO: Make sure _sqlKind matches _functionName.
Review Comment:
e.g. remove this comment. this TODO is not needed.
if you were to add comments to each individual member variables, one
suggestion would be
```
// the underlying SQL operator kind of this function. It can be either a
standard SQL operator or an extended function kind.
// @see #SqlKind.FUNCTION, #SqlKind.OTHER, #SqlKind.OTHER_FUNCTION
@ProtoProperties
private SqlKind _sqlKind;
// the return data type of the function.
@ProtoProperties
private FieldSpec.DataType _dataType;
// the name of the SQL function. For standard SqlKind it should match
the SqlKind ENUM name.
@ProtoProperties
private String _functionName;
// the list of RexExpressions that represents the operands to the
function.
@ProtoProperties
private List<RexExpression> _functionOperands;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
