walterddr commented on code in PR #9798:
URL: https://github.com/apache/pinot/pull/9798#discussion_r1023305536


##########
pinot-query-runtime/src/test/resources/queries/ValueExpressions.json:
##########
@@ -0,0 +1,102 @@
+{
+  "subscript": {
+    "psql": "4.2.3",
+    "ignored": true,
+    "comment": "query runner test doesn't yet support multivalue columns",
+    "tables": {
+      "tbl": {
+        "schema":[{"name": "data", "type": "INT[]"}],
+        "inputs": [[[1]]]
+      }
+    },
+    "queries": [{
+      "description": "test array subscripting",
+      "sql": "SELECT data[0] FROM {tbl}"
+    }]
+  },
+  "scalar_function_call": {
+    "psql": "4.2.6",
+    "tables": {
+      "tbl": {
+        "schema":[{"name": "data", "type": "STRING"}],
+        "inputs": [[" foo "]]
+      }
+    },
+    "queries": [{
+      "description": "test basic function call syntax works",
+      "sql": "SELECT trim(data) FROM {tbl}"
+    }]

Review Comment:
   i dont think this works b/c `data` seems to need escape in pinot SQL. it is 
explained into:
   ```
   rel#10:LogicalProject.(input=LogicalTableScan#7,exprs=[TRIM(FLAG(BOTH), ' ', 
$0)])
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to