wirybeaver commented on code in PR #9710:
URL: https://github.com/apache/pinot/pull/9710#discussion_r1028564167
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/SegmentFetcherFactory.java:
##########
@@ -196,4 +206,21 @@ private void fetchAndDecryptSegmentToLocalInternal(String
uri, File dest, String
crypter.decrypt(tempDownloadedFile, dest);
}
}
+
+ private void fetchAndDecryptSegmentToLocalInternal(@NonNull List<URI> uris,
File dest, String crypterName)
+ throws Exception {
+ Preconditions.checkArgument(!uris.isEmpty(), "empty uris passed into the
fetchAndDecryptSegmentToLocalInternal");
+ URI uri = uris.get(RANDOM.nextInt(uris.size()));
Review Comment:
For this PR, I won't integrate the strategy pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
