snleee commented on code in PR #9855:
URL: https://github.com/apache/pinot/pull/9855#discussion_r1031033274
##########
pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java:
##########
@@ -191,20 +182,22 @@ public void init(PinotConfiguration config) {
clientSecretCredentialBuilder.httpClient(builder.build());
dataLakeServiceClientBuilder.credential(clientSecretCredentialBuilder.build());
-
blobServiceClientBuilder.credential(clientSecretCredentialBuilder.build());
+ break;
+ }
+ case NONE: {
+ LOGGER.info("Authenticating using anonymous access");
break;
}
default:
- throw new IllegalStateException("Expecting valid authType. One of
(ACCESS_KEY, AZURE_AD, AZURE_AD_WITH_PROXY");
+ throw new IllegalArgumentException(
Review Comment:
Should we try to initialize the client using `DefaultAzureCredential` to
have a way to pass the credentials to azure client using ENV variables (or
system properties)? Or, that is not scope of this PR?
##########
pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java:
##########
@@ -191,20 +182,22 @@ public void init(PinotConfiguration config) {
clientSecretCredentialBuilder.httpClient(builder.build());
dataLakeServiceClientBuilder.credential(clientSecretCredentialBuilder.build());
-
blobServiceClientBuilder.credential(clientSecretCredentialBuilder.build());
+ break;
+ }
+ case NONE: {
+ LOGGER.info("Authenticating using anonymous access");
break;
}
default:
- throw new IllegalStateException("Expecting valid authType. One of
(ACCESS_KEY, AZURE_AD, AZURE_AD_WITH_PROXY");
+ throw new IllegalArgumentException(
Review Comment:
Should we try to initialize the client using `DefaultAzureCredential` to
have a way to pass the credentials to azure client using ENV variables (or
system properties)? Or, that is not the scope of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
