zhtaoxiang commented on PR #9864: URL: https://github.com/apache/pinot/pull/9864#issuecomment-1329444914
> @zhtaoxiang What's the concern with computing `maxValidBucketEndTimeMs` for each merge level? Since we are emitting the delay metric per (table, merge level) pair, I think that we need to compute `maxValidBucketEndTimeMs` for each merge level. > > @jtao15 Can you double check on this? 1/ If we double check the previous logic (https://github.com/apache/pinot/blob/master/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java#L628), only the lowest merge level `maxValidBucketEndTimeMs` was used to calculate the lowest merge level bucket delay. For higher levels, we use the lower level status to calculate bucket delay. 2/ If 1 is true, we only need to calculate `maxValidBucketEndTimeMs` for the lowest level, and we should not reuse the same structure `_tableMaxValidBucketEndTimeMs` to keep `maxValidBucketEndTimeMs` for different merge levels. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
