navina commented on code in PR #9851:
URL: https://github.com/apache/pinot/pull/9851#discussion_r1034350597
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##########
@@ -33,18 +34,25 @@
public class PartialUpsertHandler {
// _column2Mergers maintains the mapping of merge strategies per columns.
private final Map<String, PartialUpsertMerger> _column2Mergers = new
HashMap<>();
+ private final UpsertConfig.Strategy _defaultPartialUpsertStrategy;
+ private final String _comparisonColumn;
+ private final List<String> _primaryKeyColumns;
public PartialUpsertHandler(Schema schema, Map<String,
UpsertConfig.Strategy> partialUpsertStrategies,
UpsertConfig.Strategy defaultPartialUpsertStrategy, String
comparisonColumn) {
+ _defaultPartialUpsertStrategy = defaultPartialUpsertStrategy;
+ _comparisonColumn = comparisonColumn;
+ _primaryKeyColumns = schema.getPrimaryKeyColumns();
+
for (Map.Entry<String, UpsertConfig.Strategy> entry :
partialUpsertStrategies.entrySet()) {
_column2Mergers.put(entry.getKey(),
PartialUpsertMergerFactory.getMerger(entry.getValue()));
}
// For all physical columns (including date time columns) except for
primary key columns and comparison column.
// If no comparison column is configured, use main time column as the
comparison time.
for (String columnName : schema.getPhysicalColumnNames()) {
- if (!schema.getPrimaryKeyColumns().contains(columnName) &&
!_column2Mergers.containsKey(columnName)
- && !comparisonColumn.equals(columnName)) {
- _column2Mergers.put(columnName,
PartialUpsertMergerFactory.getMerger(defaultPartialUpsertStrategy));
+ if (!_primaryKeyColumns.contains(columnName) &&
!_column2Mergers.containsKey(columnName)
+ && !_comparisonColumn.equals(columnName)) {
+ _column2Mergers.put(columnName,
PartialUpsertMergerFactory.getMerger(_defaultPartialUpsertStrategy));
}
}
Review Comment:
ok yeah this part is redundant now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
