siddharthteotia commented on code in PR #9868:
URL: https://github.com/apache/pinot/pull/9868#discussion_r1035110294
##########
pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexHandlerReloadQueriesTest.java:
##########
@@ -644,12 +737,15 @@ private void changePropertiesAndReloadSegment()
invertedIndexEnabledColumns.add("column2");
invertedIndexEnabledColumns.add("column7");
indexLoadingConfig.setInvertedIndexColumns(invertedIndexEnabledColumns);
+ indexLoadingConfig.getInvertedIndexColumns().remove("column9");
Set<String> noDictionaryColumns = new HashSet<>(_noDictionaryColumns);
indexLoadingConfig.setNoDictionaryColumns(noDictionaryColumns);
indexLoadingConfig.getNoDictionaryColumns().remove("column2");
indexLoadingConfig.getNoDictionaryColumns().remove("column3");
indexLoadingConfig.getNoDictionaryColumns().remove("column7");
indexLoadingConfig.getNoDictionaryColumns().remove("column10");
+ indexLoadingConfig.getNoDictionaryColumns().add("column6");
+ indexLoadingConfig.getNoDictionaryColumns().add("column9");
Review Comment:
Do we handle basic validation (similar to what we did in noForwardIndex
work) at the table config level ?
For example, if someone wants to disable dictionary on a column, but does
not remove the column from the `invertedIndexColumn` list in the tableConfig
when updating the tableConfig, then we should throw error right there.
Other way would be to detect this invalid combination during reload but I
guess that's too late.
##########
pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexHandlerReloadQueriesTest.java:
##########
@@ -644,12 +737,15 @@ private void changePropertiesAndReloadSegment()
invertedIndexEnabledColumns.add("column2");
invertedIndexEnabledColumns.add("column7");
indexLoadingConfig.setInvertedIndexColumns(invertedIndexEnabledColumns);
+ indexLoadingConfig.getInvertedIndexColumns().remove("column9");
Set<String> noDictionaryColumns = new HashSet<>(_noDictionaryColumns);
indexLoadingConfig.setNoDictionaryColumns(noDictionaryColumns);
indexLoadingConfig.getNoDictionaryColumns().remove("column2");
indexLoadingConfig.getNoDictionaryColumns().remove("column3");
indexLoadingConfig.getNoDictionaryColumns().remove("column7");
indexLoadingConfig.getNoDictionaryColumns().remove("column10");
+ indexLoadingConfig.getNoDictionaryColumns().add("column6");
+ indexLoadingConfig.getNoDictionaryColumns().add("column9");
Review Comment:
Do we handle basic validation (similar to what we did in `noForwardIndex`
work) at the table config level ?
For example, if someone wants to disable dictionary on a column, but does
not remove the column from the `invertedIndexColumn` list in the tableConfig
when updating the tableConfig, then we should throw error right there.
Other way would be to detect this invalid combination during reload but I
guess that's too late.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
