KKcorps commented on code in PR #9863:
URL: https://github.com/apache/pinot/pull/9863#discussion_r1035630800
##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java:
##########
@@ -155,6 +162,17 @@ private KinesisRecordsBatch
getResult(StreamPartitionMsgOffset startOffset, Stre
if (Thread.interrupted()) {
break;
}
+
+ if (requestSentTime == currentWindow &&
getRecordsResponse.records().isEmpty()) {
Review Comment:
@navina I feel like I should remove this isEmpty check from here. Reason
being it doesn't cover the cases when we might be getting only 1-2 records on
each .getRecords request and thus exceed the throughput limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
