Jackie-Jiang commented on code in PR #9925:
URL: https://github.com/apache/pinot/pull/9925#discussion_r1042800769
##########
pinot-spi/src/test/java/org/apache/pinot/spi/plugin/PluginManagerTest.java:
##########
@@ -96,19 +96,19 @@ public void testGetPluginsToLoad()
HashMap<String, File> actualPluginsMap =
PluginManager.get().getPluginsToLoad(pluginsDirs, pluginsToInclude);
Assert.assertEquals(actualPluginsMap.size(), 3);
- ArrayList<String> actualPluginNames = new ArrayList<>();
- ArrayList<String> actualPluginPaths = new ArrayList<>();
+ HashSet<String> actualPluginNames = new HashSet<>();
Review Comment:
Let's make it a string to string map and compare the map instead of
comparing 2 sets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
