Jackie-Jiang commented on code in PR #9938:
URL: https://github.com/apache/pinot/pull/9938#discussion_r1042821192
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -105,7 +106,8 @@ public class IndexLoadingConfig {
*/
public IndexLoadingConfig(InstanceDataManagerConfig
instanceDataManagerConfig, TableConfig tableConfig,
@Nullable Schema schema) {
- extractFromInstanceConfig(instanceDataManagerConfig);
+ _instanceDataManagerConfig = instanceDataManagerConfig;
+ extractFromInstanceConfig();
Review Comment:
(minor) Let's make it consistent as how table config and schema is handled
(set `_instanceDataManagerConfig` within
`extractFromInstanceConfig(instanceDataManagerConfig)`)
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -105,7 +106,8 @@ public class IndexLoadingConfig {
*/
public IndexLoadingConfig(InstanceDataManagerConfig
instanceDataManagerConfig, TableConfig tableConfig,
@Nullable Schema schema) {
- extractFromInstanceConfig(instanceDataManagerConfig);
+ _instanceDataManagerConfig = instanceDataManagerConfig;
+ extractFromInstanceConfig();
updateTableConfigAndSchema(tableConfig, schema);
Review Comment:
Let's change this back to `extractFromTableConfigAndSchema` and make it
private to prevent people from using it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
