walterddr commented on code in PR #9940:
URL: https://github.com/apache/pinot/pull/9940#discussion_r1044604580
##########
pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java:
##########
@@ -157,6 +165,12 @@ public boolean execute()
return false;
}
+ if (_useTLS) {
+ SSLContext ctx = SSLContext.getInstance("TLS");
+ ctx.init(new KeyManager[0], new TrustManager[]{new
DefaultTrustManager()}, new SecureRandom());
+ SSLContext.setDefault(ctx);
+ }
Review Comment:
this is not the right way of configuring SSLContext.
all of these logics are currently encapsulated inside TlsUtils (see #8329).
they need to be managed and acquire properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
