walterddr commented on code in PR #9978:
URL: https://github.com/apache/pinot/pull/9978#discussion_r1047350226
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##########
@@ -100,12 +103,16 @@ public void init(PinotConfiguration config,
InstanceDataManager instanceDataMana
new NamedThreadFactory("query_worker_on_" + _port + "_port")));
_mailboxService = MultiplexingMailboxService.newInstance(_hostname,
_port, config, _scheduler::onDataAvailable);
_serverExecutor = new ServerQueryExecutorV1Impl();
- _serverExecutor.init(config, instanceDataManager, serverMetrics);
+ _serverExecutor.init(getQueryExecutorConfig(config),
instanceDataManager, serverMetrics);
} catch (Exception e) {
throw new RuntimeException(e);
}
}
+ private PinotConfiguration getQueryExecutorConfig(PinotConfiguration
pinotConfiguration) {
+ return pinotConfiguration.subset(PINOT_SERVER_QUERY);
+ }
+
Review Comment:
```suggestion
```
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##########
@@ -100,12 +103,16 @@ public void init(PinotConfiguration config,
InstanceDataManager instanceDataMana
new NamedThreadFactory("query_worker_on_" + _port + "_port")));
_mailboxService = MultiplexingMailboxService.newInstance(_hostname,
_port, config, _scheduler::onDataAvailable);
_serverExecutor = new ServerQueryExecutorV1Impl();
- _serverExecutor.init(config, instanceDataManager, serverMetrics);
+ _serverExecutor.init(getQueryExecutorConfig(config),
instanceDataManager, serverMetrics);
Review Comment:
```suggestion
_serverExecutor.init(config.subset(PINOT_SERVER_QUERY_CONFIG_PREFIX),
instanceDataManager, serverMetrics);
```
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##########
@@ -73,6 +73,9 @@
*/
public class QueryRunner {
private static final Logger LOGGER =
LoggerFactory.getLogger(QueryRunner.class);
+
+ private static final String PINOT_SERVER_QUERY =
"pinot.server.query.executor";
Review Comment:
```suggestion
private static final String PINOT_V1_SERVER_QUERY_CONFIG_PREFIX =
"pinot.server.query.executor";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
