walterddr commented on code in PR #9956:
URL: https://github.com/apache/pinot/pull/9956#discussion_r1047433083
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcMailboxService.java:
##########
@@ -89,20 +92,27 @@ public int getMailboxPort() {
* @param mailboxId the id of the mailbox.
*/
public SendingMailbox<TransferableBlock> getSendingMailbox(MailboxIdentifier
mailboxId) {
- return _sendingMailboxMap.computeIfAbsent(mailboxId.toString(), (mId) ->
new GrpcSendingMailbox(mId, this));
+ SendingMailbox<TransferableBlock> mailbox =
+ _sendingMailboxMap.computeIfAbsent(mailboxId.toString(), (mId) -> new
GrpcSendingMailbox(mId, this));
+ LOGGER.trace("GrpcMailboxService sendingMailBox size:" +
_sendingMailboxMap.size());
Review Comment:
add sendingmailbox identifier otherwise the trace is very ambiguous
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
