61yao commented on code in PR #9907:
URL: https://github.com/apache/pinot/pull/9907#discussion_r1048183644
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -42,48 +41,70 @@
/**
* This basic {@code BroadcastJoinOperator} implement a basic broadcast join
algorithm.
+ * This algorithm assumes that the broadcast table has to fit in memory since
we are not supporting any spilling.
*
+ * For left join, inner join, right join and full join,
* <p>It takes the right table as the broadcast side and materialize a hash
table. Then for each of the left table row,
* it looks up for the corresponding row(s) from the hash table and create a
joint row.
*
* <p>For each of the data block received from the left table, it will
generate a joint data block.
- *
- * We currently support left join, inner join and semi join.
+ * We currently support left join, inner join, right join and full join.
* The output is in the format of [left_row, right_row]
*/
// TODO: Move inequi out of hashjoin.
(https://github.com/apache/pinot/issues/9728)
public class HashJoinOperator extends BaseOperator<TransferableBlock> {
+ private class BroadcastRows {
+ public BroadcastRows(List<Object[]> rows, boolean hasMatch) {
+ _rows = rows;
+ _hasMatch = hasMatch;
+ }
Review Comment:
This doesn't work since left join has a bug when there is inequi condition.
we have to record _unmatchedLeftRows for left join and full join.
For right join and full join, we have to remember matched rows to output
unmatched ones.
I used HashMap<Key, HashSet<Integer>> _matchedRightRows because we have to
use this to look up unmatched rows.
PTAL at the new implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
