snleee commented on code in PR #9954:
URL: https://github.com/apache/pinot/pull/9954#discussion_r1053005212
##########
pinot-common/src/main/java/org/apache/pinot/common/minion/MinionTaskMetadataUtils.java:
##########
@@ -63,6 +68,68 @@ private static ZNRecord
fetchTaskMetadata(HelixPropertyStore<ZNRecord> propertyS
return znRecord;
}
+ /**
+ * Gets the last update time (in ms) of all minion task metadata.
+ * @param propertyStore the property store where all minion task metadata is
stored.
+ * @return a map storing the last update time (in ms) of all minion task
metadata: (tableNameWithType -> taskType
+ * -> last update time in ms)
+ */
+ @Nonnull
Review Comment:
(@Jackie-Jiang's nit) I think that we want to annotate `Nullable` only and
assume `Nonnull` by default. We can remove `@Nonnull` annotation.
##########
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/controller.yml:
##########
@@ -112,6 +112,13 @@ rules:
labels:
taskType: "$1"
status: "$2"
+- pattern: "\"org.apache.pinot.common.metrics\"<type=\"ControllerMetrics\",
name=\"pinot.controller.timeMsSinceLastMinionTaskMetadataUpdate.(\\w+)_(\\w+)\\.(\\w+)\"><>(\\w+)"
Review Comment:
I suppose that this has been tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
