richardstartin commented on code in PR #10043:
URL: https://github.com/apache/pinot/pull/10043#discussion_r1065689645
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/RangePredicateEvaluatorFactory.java:
##########
@@ -214,6 +219,16 @@ public int[] getMatchingDictIds() {
public int getNumMatchingItems() {
return Math.max(_numMatchingDictIds, 0);
}
+
+ @Override
+ public int getInclusiveLowerBound() {
+ return getStartDictId();
+ }
+
+ @Override
+ public int getInclusiveUpperBound() {
+ return getEndDictId() - 1;
Review Comment:
Pay attention to how details like the last dictionary id being exclusive can
be encapsulated with simple abstractions, rather than copying this snippet
everywhere a range query needs to be evaluated against a dictionary. It's
outside of the scope of this PR, but this pattern can be adopted in
`SortedIndexBasedFilterOperator` to reduce coupling there, and would simplify
the code changes required to introduce a sorted index without a dictionary in
the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
