mcvsubbu commented on code in PR #10083:
URL: https://github.com/apache/pinot/pull/10083#discussion_r1066440840
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java:
##########
@@ -529,11 +517,9 @@ public void initializeGlobalMeters() {
}
}
+ @Deprecated
Review Comment:
setOrUpdateTableGauge() does not provide a way to set a callback function.
Why deprecate this? How do we add a metric that is computed in the callback
function?
cc: @snleee , @zhtaoxiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
