egalpin opened a new pull request, #10119:
URL: https://github.com/apache/pinot/pull/10119

   Based on what I can see in AvgAggregationFunction.java it looks as though 
null handling is implemented, but it seems that avg is still including nulls in 
the count (where avg is implemented as sum/count).  Needs tests but opening for 
fast feedback.
   
     I confirmed this using filtering, and test data where there are only 2 
rows like this:
   
   
   | myCol |
   |-------|
   | 1     |
   | null  |
   
   
   
   No filtering:
   `SELECT avg(myCol) from myTable`
   results in `0.5`
   
   
   With filtering:
   `SELECT avg(myCol) from myTableWHERE myCol is not null`
   results in `1`
   
   
   
   Slack ref: 
https://apache-pinot.slack.com/archives/CDRCA57FC/p1673551935766969


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to