Jackie-Jiang opened a new pull request, #10151: URL: https://github.com/apache/pinot/pull/10151
Null character (byte zero) is not allowed in string values ingested into Pinot (all the string values ingested will be sanitized and all the characters after the first null character will be truncated), so we don't really need to guarantee the ordering when the input string value from the query has null character in the end because the original value is anyway modified. This can simplify the comparison logic and reduce overhead when string dictionary has paddings. E.g. if the value in the dictionary is "abc\0\0\0" after padding, the original input value could be "abc", "abc\0", "abc\0\0", "abc\0\0\0" or even "abc\0\0\0\0", "abc\0abc". After the change, the comparison result is: - = "abc" - = "abc\0" - = "abc\0\0" - = "abc\0\0\0" - < "abc\0\0\0\0" - < "abc\0a" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
