This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new aaf603d0df [hotfix] data block to string simplification (#10173)
aaf603d0df is described below
commit aaf603d0df50e688aad66211b145c665b67225a7
Author: Rong Rong <[email protected]>
AuthorDate: Tue Jan 24 11:12:46 2023 -0800
[hotfix] data block to string simplification (#10173)
---
.../pinot/common/datablock/BaseDataBlock.java | 42 ++++------------------
1 file changed, 7 insertions(+), 35 deletions(-)
diff --git
a/pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java
b/pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java
index 27f0b5f732..40940f0585 100644
---
a/pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java
+++
b/pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java
@@ -569,41 +569,13 @@ public abstract class BaseDataBlock implements DataBlock {
public String toString() {
if (_dataSchema == null) {
return _metadata.toString();
+ } else {
+ StringBuilder stringBuilder = new StringBuilder();
+ stringBuilder.append("resultSchema:").append('\n');
+ stringBuilder.append(_dataSchema).append('\n');
+ stringBuilder.append("numRows: ").append(_numRows).append('\n');
+ stringBuilder.append("metadata:
").append(_metadata.toString()).append('\n');
+ return stringBuilder.toString();
}
-
- StringBuilder stringBuilder = new StringBuilder();
- stringBuilder.append(_dataSchema).append('\n');
- stringBuilder.append("numRows: ").append(_numRows).append('\n');
-
- DataSchema.ColumnDataType[] storedColumnDataTypes =
_dataSchema.getStoredColumnDataTypes();
- _fixedSizeData.position(0);
- for (int rowId = 0; rowId < _numRows; rowId++) {
- for (int colId = 0; colId < _numColumns; colId++) {
- switch (storedColumnDataTypes[colId]) {
- case INT:
- stringBuilder.append(_fixedSizeData.getInt());
- break;
- case LONG:
- stringBuilder.append(_fixedSizeData.getLong());
- break;
- case FLOAT:
- stringBuilder.append(_fixedSizeData.getFloat());
- break;
- case DOUBLE:
- stringBuilder.append(_fixedSizeData.getDouble());
- break;
- case STRING:
- stringBuilder.append(_fixedSizeData.getInt());
- break;
- // Object and array.
- default:
- stringBuilder.append(String.format("(%s:%s)",
_fixedSizeData.getInt(), _fixedSizeData.getInt()));
- break;
- }
- stringBuilder.append("\t");
- }
- stringBuilder.append("\n");
- }
- return stringBuilder.toString();
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]