walterddr commented on code in PR #10166:
URL: https://github.com/apache/pinot/pull/10166#discussion_r1088294229
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/WorkerManager.java:
##########
@@ -97,7 +98,7 @@ public void assignWorkerToStage(int stageId, StageMetadata
stageMetadata, long r
stageMetadata.setServerInstances(new ArrayList<>(
serverInstanceToSegmentsMap.keySet()
.stream()
- .map(server -> new VirtualServer(server, 0)) // for now, only
use single virtual server
+ .map(server -> new VirtualServer(server, 0)) // the leaf stage
only has one server, so always use 0 here
Review Comment:
no it doesn't matter. as the leaf stage uses its own multi-threading runtime
(v1 engine) and thus it is not necessary to configure that here.
later once we consolidate the execution model we might want to change it but
that would require a whole lot of design changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
