jasperjiaguo commented on code in PR #10171:
URL: https://github.com/apache/pinot/pull/10171#discussion_r1088409852
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -686,6 +689,9 @@ private BrokerResponseNative handleRequest(long requestId,
String query,
_queryLogger.log(
new QueryLogger.QueryLogParams(requestId, query, requestContext,
tableName, numUnavailableSegments, serverStats,
brokerResponse, totalTimeMs, requesterIdentity));
+
+ Tracing.ThreadAccountantOps.clear();
Review Comment:
Yeah good catch, I have also seen a cleanup issue in test because of this.
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java:
##########
@@ -80,6 +80,7 @@ public enum ServerMeter implements AbstractMetrics.Meter {
READINESS_CHECK_OK_CALLS("readinessCheck", true),
READINESS_CHECK_BAD_CALLS("readinessCheck", true),
QUERIES_PREEMPTED("query", true),
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
