61yao commented on code in PR #10179:
URL: https://github.com/apache/pinot/pull/10179#discussion_r1088540354
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java:
##########
@@ -120,7 +120,7 @@ public List<MultiStageOperator> getChildOperators() {
@Override
public String toExplainString() {
_dataTableBlockBaseOperator.toExplainString();
- LOGGER.debug(_operatorStats.toString());
+ LOGGER.info(_operatorStats.toString());
Review Comment:
Can move in next PR since it is urgent.
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java:
##########
@@ -114,18 +114,23 @@ public void runJob() {
register(operatorChain, false);
} else {
if (result.isErrorBlock()) {
- operatorChain.getRoot().toExplainString();
LOGGER.error("({}): Completed erroneously {} {}",
operatorChain, operatorChain.getStats(),
result.getDataBlock().getExceptions());
} else {
- operatorChain.getRoot().toExplainString();
- LOGGER.debug("({}): Completed {}", operatorChain,
operatorChain.getStats());
+ if (operatorChain.shouldLogOpStats()) {
+ LOGGER.info("({}): Completed {}", operatorChain,
operatorChain.getStats());
+ }
}
operatorChain.close();
+ if (operatorChain.shouldLogOpStats()) {
+ operatorChain.getRoot().toExplainString();
+ }
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
