siddharthteotia commented on code in PR #10211:
URL: https://github.com/apache/pinot/pull/10211#discussion_r1093893913
##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotJoinExchangeNodeInsertRule.java:
##########
@@ -65,7 +65,7 @@ public void onMatch(RelOptRuleCall call) {
if (joinInfo.leftKeys.isEmpty()) {
// when there's no JOIN key, use broadcast.
- leftExchange = LogicalExchange.create(leftInput,
RelDistributions.SINGLETON);
+ leftExchange = LogicalExchange.create(leftInput,
RelDistributions.RANDOM_DISTRIBUTED);
rightExchange = LogicalExchange.create(rightInput,
RelDistributions.BROADCAST_DISTRIBUTED);
Review Comment:
Discussed offline with @walterddr. This is sort of faking an exchange.
My question was from the perspective that left side does not need data
movement
```
Leaf stage - scan -> filter -> project right side. NO-OP for left side
BROADCAST_EXCHANGE right side
Intermediary stage to run JOIN (can be run on same set of servers where no
data movement needed for left side)
```
Since the intermediary stage needs to run the new operators and there is no
mechanism to wait currently, we need to do it this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
