This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 41d51ed9dc refine a few logs for easier debugging (#10223)
41d51ed9dc is described below
commit 41d51ed9dc29aa5c15a0c1abfe9ed48e39ff076f
Author: Xiaobing <[email protected]>
AuthorDate: Thu Feb 2 10:34:14 2023 -0800
refine a few logs for easier debugging (#10223)
---
.../index/loader/defaultcolumn/BaseDefaultColumnHandler.java | 6 ++++++
.../pinot/tools/admin/command/StartServiceManagerCommand.java | 8 ++++----
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
index 5d647cd335..1adfbe03d1 100644
---
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
+++
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
@@ -136,6 +136,9 @@ public abstract class BaseDefaultColumnHandler implements
DefaultColumnHandler {
@Override
public boolean needUpdateDefaultColumns() {
Map<String, DefaultColumnAction> defaultColumnActionMap =
computeDefaultColumnActionMap();
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Need to update default columns with actionMap: {}",
defaultColumnActionMap);
+ }
return !defaultColumnActionMap.isEmpty();
}
@@ -147,6 +150,9 @@ public abstract class BaseDefaultColumnHandler implements
DefaultColumnHandler {
throws Exception {
// Compute the action needed for each column.
Map<String, DefaultColumnAction> defaultColumnActionMap =
computeDefaultColumnActionMap();
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Update default columns with actionMap: {}",
defaultColumnActionMap);
+ }
if (defaultColumnActionMap.isEmpty()) {
return;
}
diff --git
a/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServiceManagerCommand.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServiceManagerCommand.java
index b3274077ac..b211a2c019 100644
---
a/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServiceManagerCommand.java
+++
b/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServiceManagerCommand.java
@@ -198,8 +198,8 @@ public class StartServiceManagerCommand extends
AbstractBaseAdminCommand impleme
savePID(System.getProperty("java.io.tmpdir") + File.separator +
pidFile);
return true;
}
- } catch (Exception e) {
- LOGGER.error("Caught exception while starting pinot service, exiting.",
e);
+ } catch (Throwable t) {
+ LOGGER.error("Caught exception while starting pinot service, exiting.",
t);
}
System.exit(-1);
return false;
@@ -303,8 +303,8 @@ public class StartServiceManagerCommand extends
AbstractBaseAdminCommand impleme
LOGGER.info("Starting a Pinot [{}] at {}s since launch", role,
startOffsetSeconds());
String instanceId = serviceStarter.call();
LOGGER.info("Started Pinot [{}] instance [{}] at {}s since launch",
role, instanceId, startOffsetSeconds());
- } catch (Exception e) {
- LOGGER.error(String.format("Failed to start a Pinot [%s] at %s since
launch", role, startOffsetSeconds()), e);
+ } catch (Throwable t) {
+ LOGGER.error(String.format("Failed to start a Pinot [%s] at %s since
launch", role, startOffsetSeconds()), t);
return false;
}
return true;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
