siddharthteotia commented on code in PR #10219:
URL: https://github.com/apache/pinot/pull/10219#discussion_r1096188289
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryDispatcher.java:
##########
@@ -84,9 +87,10 @@ public ResultTable submitAndReduce(long requestId, QueryPlan
queryPlan,
return resultTable;
}
- public int submit(long requestId, QueryPlan queryPlan, long timeoutMs,
Map<String, String> queryOptions)
+ public int submit(long requestId, QueryPlan queryPlan, long deadlineNanos,
Map<String, String> queryOptions)
throws Exception {
int reduceStageId = -1;
+ Deadline deadline = Deadline.after(deadlineNanos - System.nanoTime(),
TimeUnit.NANOSECONDS);
Review Comment:
> we might later on provide a different deadline for dispatch for the
compilation.
But I feel this should be subsumed right as part of the overall query
deadline. I mean what if in a pathological scenario, dispatch for the
compilation itself exhausts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
