siddharthteotia commented on code in PR #10241:
URL: https://github.com/apache/pinot/pull/10241#discussion_r1099375564
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SortOperator.java:
##########
@@ -107,16 +114,25 @@ private TransferableBlock produceSortedBlock() {
}
if (!_isSortedBlockConstructed) {
- LinkedList<Object[]> rows = new LinkedList<>();
- while (_rows.size() > _offset) {
- Object[] row = _rows.poll();
- rows.addFirst(row);
- }
_isSortedBlockConstructed = true;
- if (rows.size() == 0) {
- return TransferableBlockUtils.getEndOfStreamTransferableBlock();
+ if (_priorityQueue == null) {
Review Comment:
Not related to changes in this PR but just wondering if
`_isSortedBlockConstructed` be volatile ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
