somandal commented on code in PR #10228:
URL: https://github.com/apache/pinot/pull/10228#discussion_r1099651444
##########
pinot-query-planner/src/test/resources/queries/OrderBy.json:
##########
@@ -0,0 +1,58 @@
+{
+ "order_by_planning_tests": {
Review Comment:
I have added alias tests for all the plan files. Some of the
`WindowFunctionPlans` are behaving weird in terms of the alias and others seem
to work fine. I've added TODOs to look into why. Let me know if you think this
needs further digging before we decide to merge.
##########
pinot-query-planner/src/test/resources/queries/Aggregates.json:
##########
@@ -0,0 +1,34 @@
+{
+ "aggregates_planning_tests": {
Review Comment:
done renamed them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
