zhtaoxiang commented on code in PR #10239:
URL: https://github.com/apache/pinot/pull/10239#discussion_r1099739928
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -541,6 +541,41 @@ public SuccessResponse resetSegment(
}
}
+ /**
+ * Resets segments with Error EV of the given table
+ * This API will take segments to OFFLINE state, wait for External View to
stabilize, and then back to
+ * ONLINE/CONSUMING state,
+ * thus effective in resetting segments or consumers in error states.
+ */
+ @POST
+ @Path("segments/{tableNameWithType}/resetErrorEvSegments")
Review Comment:
make sense, updated
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2430,11 +2429,41 @@ public void resetSegment(String tableNameWithType,
String segmentName, @Nullable
}
}
+ /**
+ * Resets segments with Error EV of a table. This operation invoke
resetPartition via state transition message.
+ */
+ public void resetErrorEvSegments(String tableNameWithType, @Nullable String
targetInstance) {
Review Comment:
make sense, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
