ankitsultana commented on code in PR #10258:
URL: https://github.com/apache/pinot/pull/10258#discussion_r1102091040
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -557,8 +561,7 @@ static void validateUpsertAndDedupConfig(TableConfig
tableConfig, Schema schema)
"Upsert/Dedup table must use low-level streaming consumer type");
// replica group is configured for routing
Preconditions.checkState(tableConfig.getRoutingConfig() != null
- &&
RoutingConfig.STRICT_REPLICA_GROUP_INSTANCE_SELECTOR_TYPE.equalsIgnoreCase(
- tableConfig.getRoutingConfig().getInstanceSelectorType()),
+ &&
isRoutingStrategyAllowedForUpsert(tableConfig.getRoutingConfig()),
Review Comment:
FYI: I left the message for this Precondition as is (it still says `i.e.
strictReplicaGroup`). Reason is that multi-stage routing strategy is in beta so
we don't want to bubble it up to the users yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
