Jackie-Jiang commented on code in PR #10275:
URL: https://github.com/apache/pinot/pull/10275#discussion_r1105082864
##########
pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3Config.java:
##########
@@ -100,9 +100,9 @@ public S3Config(PinotConfiguration pinotConfig) {
Integer.parseInt(pinotConfig.getProperty(SESSION_DURATION_SECONDS,
DEFAULT_SESSION_DURATION_SECONDS));
_asyncSessionUpdateEnabled = Boolean.parseBoolean(
pinotConfig.getProperty(ASYNC_SESSION_UPDATED_ENABLED,
DEFAULT_ASYNC_SESSION_UPDATED_ENABLED));
- // non-positive values to disable multipart upload.
+ // Setting to 0 to disable multipart upload by default for backward
compatibility.
_minObjectSizeForMultiPartUpload =
-
DataSizeUtils.toBytes(pinotConfig.getProperty(MIN_OBJECT_SIZE_FOR_MULTI_PART_UPLOAD,
"-1"));
+
DataSizeUtils.toBytes(pinotConfig.getProperty(MIN_OBJECT_SIZE_FOR_MULTI_PART_UPLOAD,
"0"));
Review Comment:
Should we put a default value according to s3 (e.g. 5G)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
