gortiz commented on code in PR #10270:
URL: https://github.com/apache/pinot/pull/10270#discussion_r1112964704


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##########
@@ -190,4 +191,25 @@ public static Integer getGroupTrimThreshold(Map<String, 
String> queryOptions) {
     String groupByTrimThreshold = 
queryOptions.get(QueryOptionKey.GROUP_TRIM_THRESHOLD);
     return groupByTrimThreshold != null ? 
Integer.parseInt(groupByTrimThreshold) : null;
   }
+
+  // Sample input: k1:1/k1:2/k1:3/k2:4/k2:5/k2:6
+  // Sample output: {k1=[1, 2, 3], k2=[4, 5, 6]}
+  public static Map<String, Set<Integer>> getColumnPartitionMap(Map<String, 
String> queryOptions) {
+    Map<String, Set<Integer>> columnPartitionMap = new HashMap<>();
+    String columnPartitionConfig = 
queryOptions.get(QueryOptionKey.COLUMN_PARTITION_MAP);
+    if (columnPartitionConfig != null) {
+      String[] columnPartitions = columnPartitionConfig.split("/");

Review Comment:
   If we insist to support this syntax, I would include a preprocess phase 
where `\/` means to escape a `/`, `\:` means to skip a `:` and `\\` means to 
skip a `\`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to