yuanbenson commented on code in PR #10303:
URL: https://github.com/apache/pinot/pull/10303#discussion_r1113574438
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java:
##########
@@ -139,6 +139,14 @@ void addOrReplaceSegment(String segmentName,
IndexLoadingConfig indexLoadingConf
*/
List<SegmentDataManager> acquireAllSegments();
+ /**
+ * Acquires all segments of the table.
+ * <p>It is the caller's responsibility to return the segments by calling
{@link #releaseSegment(SegmentDataManager)}.
+ *
+ * @return List of segment data managers
+ */
Review Comment:
Good catch, addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
