KKcorps commented on code in PR #10299:
URL: https://github.com/apache/pinot/pull/10299#discussion_r1113810048
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/queries/ResourceBasedQueriesTest.java:
##########
@@ -260,6 +294,48 @@ private static Object[][]
testResourceQueryTestCaseProviderBoth()
return providerContent.toArray(new Object[][]{});
}
+ @DataProvider
+ private static Object[][] testResourceQueryTestCaseProviderWithMetadata()
+ throws Exception {
+ Map<String, QueryTestCase> testCaseMap = getTestCases();
+ List<Object[]> providerContent = new ArrayList<>();
+ for (Map.Entry<String, QueryTestCase> testCaseEntry :
testCaseMap.entrySet()) {
+ String testCaseName = testCaseEntry.getKey();
+ if (testCaseEntry.getValue()._ignored) {
+ continue;
+ }
+
+ List<QueryTestCase.Query> queryCases = testCaseEntry.getValue()._queries;
+ for (QueryTestCase.Query queryCase : queryCases) {
+ if (queryCase._ignored) {
+ continue;
+ }
+
+ if (queryCase._outputs != null) {
+ String sql = replaceTableName(testCaseName, queryCase._sql);
+ if (!sql.contains("basic_test")) {
+ continue;
+ }
Review Comment:
Can't do for all test cases since the metrics contain only segments queries
from the servers but doesn't account for the segments that are pruned by the
brokers. So in some cases the test fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
