ankitsultana commented on code in PR #10319:
URL: https://github.com/apache/pinot/pull/10319#discussion_r1114989027
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java:
##########
@@ -100,6 +102,7 @@ public void runJob() {
if (isFinished) {
closeOpChain(operatorChain);
} else if (thrown != null) {
+ // TODO: It would make sense to cancel OpChains if they returned
an error-block.
Review Comment:
Yeah right now that's the case. In a follow-up I'll most likely change this
behavior to:
```
finally {
if (thrown != null || returnedErrorBlock) {
cancelOpChain(operatorChain);
} else if (isFinished) {
closeOpChain(operatorChain);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
