cgenrich commented on PR #10326: URL: https://github.com/apache/pinot/pull/10326#issuecomment-1444456251
> Thanks a lot for the contribution! > > Can you also add an example in the PR on what changes a person should make to the caller code for better performance. Considering, the caller now needs to handle future lifecycle properly (since earlier it was just working as pseudo-blocking implementation). Are you asking for the example in the javadocs? Should it be in the main portion of Connection or on each of the async methods? Or are you looking for something in https://github.com/pinot-contrib/pinot-docs. Do you want examples from some web framework or just using CompletableFuture then, when, etc. chains? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
