cbalci commented on code in PR #10321:
URL: https://github.com/apache/pinot/pull/10321#discussion_r1117753596
##########
pinot-connectors/pinot-spark-common/src/main/java/org/apache/pinot/connector/spark/common/CaseInsensitiveStringMap.java:
##########
@@ -0,0 +1,201 @@
+/**
Review Comment:
Thanks for the review @xiangfu0 !
I think this class enables the simplest interface we can expose to the
implementor: `Map[String,String]`.
If you take a look at the `PinotDataSourceReadOptions` below, it has two
factory methods with following signatures:
```
object PinotDataSourceReadOptions {
...
private[pinot] def from(optionsMap: util.Map[String, String]):
PinotDataSourceReadOptions
...
private[pinot] def from(options: CaseInsensitiveStringMap):
PinotDataSourceReadOptions
...
}
```
With this, the shared `PinotDataSourceOptions` object can be created either
by passing a `CaseInsensitiveStringMap` or a plain old `Map` which internally
will be converted to a `CaseInsensitiveStringMap`. I guess we can even drop the
second method and only accept `Map[String, String]` for simplicity.
Let me know if you meant something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
