Jackie-Jiang commented on code in PR #10328:
URL: https://github.com/apache/pinot/pull/10328#discussion_r1117848009
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java:
##########
@@ -40,6 +40,10 @@ public static ValueAggregator
getValueAggregator(AggregationFunctionType aggrega
return new MaxValueAggregator(dataType);
case SUM:
return new SumValueAggregator(dataType);
+ case DISTINCTCOUNTRAWHLL:
Review Comment:
The stored value has to be serialized bytes, but we can still apply
`DISTINCTCOUNTHLL` on serialized HLLs. The difference between raw and non-raw
is only the final return result, where the raw one returns the HLL, the non-raw
returns the count
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
